bpo-46530: add `"thread_time"` to `test_time.test_get_clock_info` by sobolevn · Pull Request #30913 · python/cpython

sobolevn · 2022-01-26T09:03:54Z

Originally discovered here: python/typeshed#7040

https://bugs.python.org/issue46530

JelleZijlstra · 2022-01-28T05:38:19Z

@gvanrossum I think this one can be merged.

gvanrossum

Agreed.

bedevere-bot · 2022-01-28T05:43:03Z

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

gvanrossum · 2022-01-28T05:43:29Z

Backports?

bedevere-bot · 2022-01-28T05:54:45Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit c27a331.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/884) and take a look at the build logs.
Check if the failure is related to this commit (c27a331) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/884

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

411 tests OK.

10 slowest tests:

test_concurrent_futures: 3 min 40 sec
test_multiprocessing_spawn: 2 min 32 sec
test_multiprocessing_forkserver: 1 min 48 sec
test_unparse: 1 min 22 sec
test_asyncio: 1 min 19 sec
test_tokenize: 1 min 12 sec
test_nntplib: 1 min 1 sec
test_logging: 1 min 1 sec
test_lib2to3: 54.4 sec
test_capi: 51.2 sec

1 test altered the execution environment:
test_ftplib

17 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_gdb test_ioctl
test_msilib test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 9 min 16 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_819f7dae'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 90, in read
    obj.handle_read_event()
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 384, in handle_read_event
    self._do_ssl_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 345, in _do_ssl_handshake
    self.socket.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1345, in do_handshake
    self._sslobj.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:998)


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1031, in _bootstrap_inner
    self.run()
    ^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 298, in run
    asyncore.loop(timeout=0.1, count=1)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 214, in loop
    poll_fun(timeout, map)
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 157, in poll
    read(obj)
    ^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 94, in read
    obj.handle_error()
    ^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 421, in handle_error
    raise Exception
    ^^^^^^^^^^^^^^^
Exception
k


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_73cb4237'

miss-islington · 2022-01-28T06:03:27Z

Thanks @sobolevn for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington · 2022-01-28T06:03:27Z

Thanks @sobolevn for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot · 2022-01-28T06:03:37Z

GH-30977 is a backport of this pull request to the 3.9 branch.

…thonGH-30913) (cherry picked from commit c27a331) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot · 2022-01-28T06:03:42Z

GH-30978 is a backport of this pull request to the 3.10 branch.

sobolevn · 2022-01-28T06:03:55Z

Failures look unrelated 🤔

Both backports make sense:

…-30913) (cherry picked from commit c27a331) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot · 2022-01-28T16:59:14Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 3.9 has failed when building commit ce5c637.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/866/builds/2) and take a look at the build logs.
Check if the failure is related to this commit (ce5c637) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/866/builds/2

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 5, done.        
remote: Counting objects:  25% (1/4)        
remote: Counting objects:  50% (2/4)        
remote: Counting objects:  75% (3/4)        
remote: Counting objects: 100% (4/4)        
remote: Counting objects: 100% (4/4), done.        
remote: Compressing objects:  33% (1/3)        
remote: Compressing objects:  66% (2/3)        
remote: Compressing objects: 100% (3/3)        
remote: Compressing objects: 100% (3/3), done.        
remote: Total 5 (delta 1), reused 1 (delta 1), pack-reused 1        
From https://github.com/python/cpython
 * branch                  3.9        -> FETCH_HEAD
Previous HEAD position was 8cd82461f9 [bpo-46542](https://bugs.python.org/issue46542): test_json uses support.infinite_recursion() (GH-30972)
HEAD is now at ce5c637f5a [bpo-46530](https://bugs.python.org/issue46530): add `"thread_time"` to `test_time.test_get_clock_info` (GH-30913)
Switched to and reset branch '3.9'

configure: WARNING: unrecognized options: --without-static-libpython
configure: WARNING: unrecognized options: --without-static-libpython

../Modules/signalmodule.c: In function ‘signal_siginterrupt_impl’:
../Modules/signalmodule.c:663:5: warning: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Wdeprecated-declarations]
  663 |     if (siginterrupt(signalnum, flag)<0) {
      |     ^~
In file included from ../Modules/signalmodule.c:28:
/usr/include/signal.h:324:12: note: declared here
  324 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
ar: libpython3.9d.a: No space left on device
make: *** [Makefile:655: libpython3.9d.a] Error 1
make: *** Waiting for unfinished jobs....
lto1: fatal error: error writing to /tmp/ccTsmvVZ.s: No space left on device
compilation terminated.
lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
ln: failed to access 'libpython3.9d.so.1.0': No such file or directory
make: *** [Makefile:658: libpython3.9d.so] Error 1

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:1875: clean-retain-profile] Error 1 (ignored)

JelleZijlstra · 2022-01-28T17:42:20Z

Look at you, making the buildbots run out of disk space.

(This one also looks unrelated. The buildbot ran out of space before it even finished compiling the interpreter.)

sobolevn · 2022-01-28T17:48:47Z

Look at you, making the buildbots run out of disk space.

If I can break something, I will break it 😒
I should have been a QA engineer! 😆

Maybe we should create a new issue in buildbot repo to increase server sizes?

bedevere-bot · 2022-01-28T23:10:49Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE CentOS9 LTO 3.9 has failed when building commit ce5c637.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/826/builds/44) and take a look at the build logs.
Check if the failure is related to this commit (ce5c637) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/826/builds/44

Summary of the results of the build (if available):

Click to see traceback logs

Note: switching to 'ce5c637f5ae06f2a6a6e966524af9d0cc816bd3f'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at ce5c637f5a [bpo-46530](https://bugs.python.org/issue46530): add `"thread_time"` to `test_time.test_get_clock_info` (GH-30913)
Switched to and reset branch '3.9'

Python/compile.c: In function ‘compiler_comprehension’:
Python/compile.c:857:27: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
  857 |     (c)->u->u_lineno = (x)->lineno;             \
      |                        ~~~^~~~~~~~
./Modules/signalmodule.c: In function ‘signal_siginterrupt_impl’:
./Modules/signalmodule.c:663:5: warning: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Wdeprecated-declarations]
  663 |     if (siginterrupt(signalnum, flag)<0) {
      |     ^~
In file included from ./Modules/signalmodule.c:28:
/usr/include/signal.h:324:12: note: declared here
  324 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
./Modules/_io/textio.c: In function ‘textiowrapper_build_cookie’:
./Modules/_io/textio.c:2387:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
 2387 | textiowrapper_build_cookie(cookie_type *cookie)
      | ^
./Modules/_io/textio.c: In function ‘textiowrapper_build_cookie’:
./Modules/_io/textio.c:2387:1: note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
 2387 | textiowrapper_build_cookie(cookie_type *cookie)
      | ^
At top level:
lto1: fatal error: error writing to /tmp/ccppn6uo.s: No space left on device
compilation terminated.
lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make: *** [Makefile:604: python] Error 1
make: *** Waiting for unfinished jobs....
At top level:
lto1: fatal error: error writing to /tmp/ccXZLRqN.s: No space left on device
compilation terminated.
lto-wrapper: fatal error: gcc returned 1 exit status
compilation terminated.
/usr/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
make: *** [Makefile:739: Programs/_testembed] Error 1

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make: [Makefile:1875: clean-retain-profile] Error 1 (ignored)

…thonGH-30913) (cherry picked from commit c27a331) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bpo-46530: add "thread_time" to test_time.test_get_clock_info

ef75551

sobolevn requested review from abalkin and pganssle as code owners January 26, 2022 09:03

the-knights-who-say-ni added the CLA signed label Jan 26, 2022

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 26, 2022

sobolevn added the skip news label Jan 26, 2022

sobolevn commented Jan 26, 2022

View reviewed changes

Comment thread Lib/test/test_time.py Outdated

Update Lib/test/test_time.py

e1276e2

JelleZijlstra approved these changes Jan 26, 2022

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Jan 26, 2022

gvanrossum approved these changes Jan 28, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jan 28, 2022

gvanrossum merged commit c27a331 into python:main Jan 28, 2022

bedevere-bot removed the awaiting merge label Jan 28, 2022

sobolevn added needs backport to 3.9 needs backport to 3.10 only security fixes labels Jan 28, 2022

bedevere-bot removed the needs backport to 3.9 label Jan 28, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 28, 2022

bpo-46530: add "thread_time" to test_time.test_get_clock_info (py…

4a9ac14

…thonGH-30913) (cherry picked from commit c27a331) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 28, 2022

bpo-46530: add "thread_time" to test_time.test_get_clock_info (py…

c6f2f3f

…thonGH-30913) (cherry picked from commit c27a331) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 28, 2022

miss-islington added a commit that referenced this pull request Jan 28, 2022

bpo-46530: add "thread_time" to test_time.test_get_clock_info (GH…

ce5c637

…-30913) (cherry picked from commit c27a331) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

miss-islington added a commit that referenced this pull request Jan 28, 2022

bpo-46530: add "thread_time" to test_time.test_get_clock_info (GH…

95b70e2

…-30913) (cherry picked from commit c27a331) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022

bpo-46530: add "thread_time" to test_time.test_get_clock_info (py…

6c51d0e

…thonGH-30913) (cherry picked from commit c27a331) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Uh oh!

Conversation

sobolevn commented Jan 26, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JelleZijlstra commented Jan 28, 2022

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jan 28, 2022

Uh oh!

gvanrossum commented Jan 28, 2022

Uh oh!

bedevere-bot commented Jan 28, 2022

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

miss-islington commented Jan 28, 2022

Uh oh!

miss-islington commented Jan 28, 2022

Uh oh!

bedevere-bot commented Jan 28, 2022

Uh oh!

bedevere-bot commented Jan 28, 2022

Uh oh!

sobolevn commented Jan 28, 2022

Uh oh!

bedevere-bot commented Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

JelleZijlstra commented Jan 28, 2022

Uh oh!

sobolevn commented Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Jan 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sobolevn commented Jan 26, 2022 •

edited by bedevere-bot

Loading

bedevere-bot commented Jan 28, 2022 •

edited

Loading

sobolevn commented Jan 28, 2022 •

edited

Loading

bedevere-bot commented Jan 28, 2022 •

edited

Loading