C#: Implement correct behavior for dotnet build tracing
#9705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For proper C# tracing, `dotnet build` needs the parameter /p:UseSharedCompilation=false. However, we can't pass that to the other subcommands of `dotnet`, therefore we need to figure out which subcommand of `dotnet` is being invoked.
tamasvajk
approved these changes
Jun 27, 2022
| -- The dotnet CLI has the following usage instructions: | ||
| -- dotnet [sdk-options] [command] [command-options] [arguments] | ||
| -- we are interested in dotnet build, which has the following usage instructions: | ||
| -- dotnet [options] build [<PROJECT | SOLUTION>...] | ||
| -- however, `dotnet -h build`, although documented, does not work | ||
| -- For now, parse the command line as follows: | ||
| -- Everything that starts with `-` will be ignored. | ||
| -- The first non-option argument is treated as the command. | ||
| -- if that's `build`, we append `/p:UseSharedCompilation=false` to the command line, | ||
| -- otherwise we do nothing. |
There was a problem hiding this comment.
Passing -d before the build command works. But I think ignoring everything that starts with- is correct and will handle this case too.
| -- dotnet [options] build [<PROJECT | SOLUTION>...] | ||
| -- however, `dotnet -h build`, although documented, does not work | ||
| -- For now, parse the command line as follows: | ||
| -- Everything that starts with `-` will be ignored. |
There was a problem hiding this comment.
This line could also state that anything prefixed / will be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
For proper C# tracing,
dotnet buildneeds the parameter/p:UseSharedCompilation=false. However, we can't pass that to the othersubcommands of
dotnet, therefore we need to figure out which subcommandof
dotnetis being invoked.