Skip to content

gh-78913: Delayed check of UUID version on actual instance#9417

Closed
conqp wants to merge 5 commits into
python:mainfrom
conqp:master
Closed

gh-78913: Delayed check of UUID version on actual instance#9417
conqp wants to merge 5 commits into
python:mainfrom
conqp:master

Conversation

@conqp

@conqp conqp commented Sep 19, 2018

Copy link
Copy Markdown

Delayed version testing to after setting `int` for testing on actual instance.
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@hauntsaninja hauntsaninja changed the title bpo-34732: Delayed check of UUID version on actual instance gh-78913: Delayed check of UUID version on actual instance Feb 9, 2023
@arhadthedev

Copy link
Copy Markdown
Member

Planning to close in favor of gh-9413. From #78913 (comment):

I'm specifically worried by the _windll() example in PR 53663, in which a non-RFC 4122 conforming UUID is created, leading to the addition of the new "strict" keyword argument so that we can disable the new check in __init__ in this case. There's a good chance that there are other such scenarios of which we're simply not yet aware.

In light of this, returning None for UUID.version, as in PR 53659, actually seems like a very reasonable solution.

@arhadthedev arhadthedev added the pending The issue will be closed if no feedback is provided label Apr 15, 2023
@jophinep jophinep mannequin mentioned this pull request Apr 15, 2023
@erlend-aasland erlend-aasland removed the pending The issue will be closed if no feedback is provided label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants