gh-62764: Fix integer overflow in socketmodule.#12864
Conversation
This migrates issue18564.3.patch from https://bugs.python.org/issue18564 into a git commit, as requested by Cheryl Sabella.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
| msg = '"{addr} is not a valid address.'.format(addr=addr) | ||
| with self.assertRaisesRegex(OSError, 'bad bluetooth address', msg=msg) as cm: | ||
| self.bs.connect((addr, 1)) | ||
| self.assertIsNone(cm.exception.errno, msg) |
There was a problem hiding this comment.
Shouldn't we check that that errno is some expected value? EINVAL? Also, why are you passing in msg here?
arhadthedev
changed the title
|
There is no integer overflow here. |
7 participants
This migrates issue18564.3.patch from https://bugs.python.org/issue18564
into a git commit, as requested by Cheryl Sabella.
https://bugs.python.org/issue18564