gh-97008: Add a Python implementation of AttributeError and NameError suggestions#97022
Merged
ambv merged 12 commits intopython:mainfrom Oct 4, 2022
Merged
gh-97008: Add a Python implementation of AttributeError and NameError suggestions#97022ambv merged 12 commits intopython:mainfrom
ambv merged 12 commits intopython:mainfrom
Conversation
…eError suggestions Relevant tests moved from test_exceptions to test_traceback to be able to compare both implementations. Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
cfbolz
reviewed
Sep 22, 2022
iritkatriel
reviewed
Sep 22, 2022
sweeneyde
reviewed
Sep 22, 2022
sweeneyde
reviewed
Sep 22, 2022
pablogsal
reviewed
Oct 4, 2022
pablogsal
approved these changes
Oct 4, 2022
Member
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
LGTM
I left a comment with a nit
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
…eError suggestions (python#97022) Relevant tests moved from test_exceptions to test_traceback to be able to compare both implementations. Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant tests moved from test_exceptions to test_traceback to be able to compare both implementations.
Co-authored-by: Carl Friedrich Bolz-Tereick cfbolz@gmx.de