Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-31165: Detect mutated list in list_slice() #3911
Closed
Conversation
Check if the list size changed before/after allocating a new list object to prevent a crash.
This comment has been minimized.
This comment has been minimized.
|
This PR lacks an unit test. I wrote it to show my idea to fix https://bugs.python.org/issue31165 without touching the garbage collector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedOct 6, 2017
•
edited by bedevere-bot
Check if the list size changed before/after allocating a new list
object to prevent a crash.
https://bugs.python.org/issue31165