Python: Add Str class#9852
Merged
Merged
Conversation
This makes the AST viewer (which annotates string constant nodes as `Str`) a bit more consistent.
RasmusWL
approved these changes
Aug 22, 2022
Member
RasmusWL
left a comment
RasmusWL
left a comment
There was a problem hiding this comment.
As a fix for people using AST viewer, this LGTM! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the AST viewer (which annotates string constant nodes as
Str, and notStrConst) a bit more consistent.Fixes #9833.
It might be even better to instead flip the inheritance and make
Strthe lowest class in the hierarchy. That way, it would have access to all of the methods onStrConst(and indeed, we might consider just deprecating that class).This is a very minor change, so I don't think a change note is required.