feat(android-timer): setInterval closer to web spec#9044
Merged
Conversation
Contributor
Author
|
Concerns about this are if |
edusperoni
changed the title
Contributor
Author
|
Just tested this on iOS and it's already working properly. I believe this can be merged |
NathanWalker
approved these changes
Nov 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
setInterval on Android will keep delaying if busy work is done during the callback
setInterval(..., 1000)will almost never call 10 times every exact 10s.What is the new behavior?
setInterval now works like the web, calling every x ms, which means sometimes it'll call more/less often depending on the amount of work being done.
setInterval(..., 1000)will almost always call 10 times every 10s (exception is if work took longer than 1000ms to be called)