Add vm-tracing-logging feature#4200
Open
jopemachine wants to merge 2 commits into
Open
Conversation
DimitrisJim
reviewed
May 19, 2023
| /// based on the return code of the python code ran through the cli. | ||
| pub fn run(init: impl FnOnce(&mut VirtualMachine) + 'static) -> ExitCode { | ||
| env_logger::init(); | ||
| if cfg!(feature = "vm-tracing-logging") { |
Member
There was a problem hiding this comment.
isn't this typically done with some ENV var instead of a feature? I'm legitimately curious here since I'm not sure but it feels as if a feature is a big of a heavy handed approach to this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracewhen "vm-tracing-logging" feature is enabled.rustpython-vm