feat(core): Repeater multiple item templates implementation by CatchABus · Pull Request #8981 · NativeScript/NativeScript

CatchABus · 2020-10-22T18:34:08Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

What is the current behavior?

Repeater does not support multiple item templates. This is a quite a limitation for NativeScript Core since it does not support any other iteration methods.

What is the new behavior?

This is my previous patch with further improvements and additions along with NativeScript 7 support.
Repeater will support multiple item templates using keys, just like ListView.
This time I included tests along with ui sample to provide a full solution.

Implements/Closes #3781 .

If issues occur, we can discuss about how to improve this feature. :)

cla-bot · 2020-10-22T18:34:11Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2020-10-22T18:41:51Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2020-10-22T18:43:42Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2020-10-22T18:43:44Z

The cla-bot has been summoned, and re-checked this pull request!

cla-bot · 2020-10-22T18:50:45Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2020-10-22T18:50:47Z

The cla-bot has been summoned, and re-checked this pull request!

CatchABus · 2020-10-22T19:29:44Z

@cla-bot check

cla-bot · 2020-10-22T19:29:45Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2020-10-22T19:29:46Z

The cla-bot has been summoned, and re-checked this pull request!

CatchABus · 2020-10-22T19:43:24Z

I apologize for this spam of cla-bot. I fixed commit author details and CLA problem is gone.
If it's possible to delete few of cla-bot posts, it would be awesome.

EDITED: About travis-ci failing, I see there is an irrelevant error that also occurs on other newest PRs.

NathanWalker

Great work @dimitrisrk thank you.

cla-bot · 2020-10-26T08:41:33Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

CatchABus · 2020-10-26T08:59:29Z

@NathanWalker All done, thank you very much for guidance!

CatchABus mentioned this pull request Oct 22, 2020

feat: implementing multiple templates for Repeater #8684

Closed

5 tasks

cla-bot Bot added the cla: yes label Oct 22, 2020

CatchABus changed the title ~~feat: Repeater multiple item templates implementation~~ feat(core): Repeater multiple item templates implementation Oct 23, 2020

NathanWalker approved these changes Oct 25, 2020

View reviewed changes

NathanWalker requested changes Oct 26, 2020

View reviewed changes

Comment thread package.json Outdated

Comment thread apps/automated/package.json Outdated

Comment thread apps/ui/package.json Outdated

CatchABus added 4 commits October 26, 2020 08:34

feat: Added multiple item templates support for repeaters.

a294148

test: Added tests for new Repeater functionality.

85199f6

chore: Minor correction.

f9bcdd2

chore: Just a commit to fix CLA.

5250e91

cla-bot Bot removed the cla: yes label Oct 26, 2020

chore: Removed unwanted dependencies from package.json files.

716e70a

cla-bot Bot added the cla: yes label Oct 26, 2020

NathanWalker approved these changes Oct 27, 2020

View reviewed changes

NathanWalker merged commit b113f19 into NativeScript:master Oct 27, 2020

Uh oh!

Conversation

CatchABus commented Oct 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

What is the current behavior?

What is the new behavior?

Uh oh!

cla-bot Bot commented Oct 22, 2020

Uh oh!

cla-bot Bot commented Oct 22, 2020

Uh oh!

cla-bot Bot commented Oct 22, 2020

Uh oh!

cla-bot Bot commented Oct 22, 2020

Uh oh!

cla-bot Bot commented Oct 22, 2020

Uh oh!

cla-bot Bot commented Oct 22, 2020

Uh oh!

CatchABus commented Oct 22, 2020

Uh oh!

cla-bot Bot commented Oct 22, 2020

Uh oh!

cla-bot Bot commented Oct 22, 2020

Uh oh!

CatchABus commented Oct 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NathanWalker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cla-bot Bot commented Oct 26, 2020

Uh oh!

CatchABus commented Oct 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CatchABus commented Oct 22, 2020 •

edited

Loading

CatchABus commented Oct 22, 2020 •

edited

Loading