fix: '__exportStar undefined'#8591
Closed
vtrifonov wants to merge 1 commit into
Closed
Conversation
Contributor
|
We're holding on 3.9.3 ts support until some other framework integrations catch up. |
Contributor
|
This workaround will no longer be needed given #8693 refactors entire codebase to work with TS 3.9 and beyond. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When using typescript version 3.9.3 the generated files in the tns-core-modules package look like:
and for the older versions it looks like:
The problem is that if we register __exportStar function in the ts-helpers.ts file which is called inside the application module, but if we load the application through the tns-core-modules package like this:
this will call the code in the beginning and there will be no __exportStar yet.
What is the new behavior?
To fix that I've added the compiled js content inside the tns-core-modules-package/application/ folder and ignored the application/application.ts in package's tsconfig.json file as I have the js file already. In that js file, I'm requiring the ts-hepers module which will register the needed __exportStar function.
Fixes #8590.