Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): nested frames were sometimes not recreated #9725

Merged
merged 1 commit into from Dec 31, 2021
Merged

fix(android): nested frames were sometimes not recreated #9725

merged 1 commit into from Dec 31, 2021

Conversation

edusperoni
Copy link
Contributor

@edusperoni edusperoni commented Dec 31, 2021

PR Checklist

What is the current behavior?

Nested frames get into inconsistent states when destroyed and recreated.

What is the new behavior?

We attempt to manually recreate the frames when android doesn't magically do it for us.

BREAKING CHANGES:

AndroidFragmentCallbacks now requires onResume as well

Migration steps:
specify onResume on custom fragment implementations

@cla-bot cla-bot bot added the cla: yes label Dec 31, 2021
@NathanWalker NathanWalker changed the base branch from master to release/8.2.0 Dec 31, 2021
@NathanWalker NathanWalker merged commit 72b01c2 into release/8.2.0 Dec 31, 2021
2 of 3 checks passed
@NathanWalker NathanWalker deleted the fix/nested-frame-fragments branch Dec 31, 2021
@edusperoni edusperoni mentioned this pull request Jan 2, 2022
Closed
@edusperoni edusperoni mentioned this pull request Jan 3, 2022
Draft
5 tasks
@NathanWalker NathanWalker restored the fix/nested-frame-fragments branch Jan 26, 2022
@rigor789 rigor789 mentioned this pull request Jan 26, 2022
Merged
NathanWalker pushed a commit that referenced this issue Feb 14, 2022
@edusperoni @NathanWalker
fix(android): nested frames were sometimes not recreated (#9725)
dfefe61 
BREAKING CHANGE:

AndroidFragmentCallbacks now requires onResume as well

Migration steps:
specify onResume on custom fragment implementations
NathanWalker pushed a commit that referenced this issue Feb 18, 2022
@edusperoni @NathanWalker
fix(android): nested frames were sometimes not recreated (#9725)
6af2658 
BREAKING CHANGE:

AndroidFragmentCallbacks now requires onResume as well

Migration steps:
specify onResume on custom fragment implementations
NathanWalker pushed a commit that referenced this issue Mar 1, 2022
@edusperoni @NathanWalker
fix(android): nested frames were sometimes not recreated (#9725)
902a4c6 
BREAKING CHANGE:

AndroidFragmentCallbacks now requires onResume as well

Migration steps:
specify onResume on custom fragment implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edusperoni @NathanWalker