fix(styling): change transform parameters parsing #9481
Conversation
Fixed the incorrectly applied short form of "transform: translate" style property. NativeScript#5202
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Actually, this looks strange because I've already signed a CLA when submitting #8998 pull request |
|
IIRC the cla changed when Nativescript joined the OpenJS Collective, which is why a lot of previous contributors are having to sign them again |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Fixed test for the translate property which had to be changed according to the changed logic NativeScript#5202
|
It seems tests fail due to timeout. Should I care about this somehow? |
I kicked off a new run, should hopefully finish without a timeout this time |
|
Thank you @SergeyMell |
NathanWalker
merged commit dbaab58
into
NativeScript:release/8.1.0
Fixed the incorrectly applied short form of "transform: translate" style property. closes #5202
Fixed the incorrectly applied short form of "transform: translate" style property.
#5202
PR Checklist
What is the current behavior?
#5202
What is the new behavior?
For now "transform: translate(10)" style property is treated as "transform: translate(10, 0)". All other options remain the same
FIxes #5202
The text was updated successfully, but these errors were encountered: