Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onSaveInstanceState should not crash when no rootView is set #9447

Merged
merged 2 commits into from Aug 11, 2021

Conversation

@edusperoni
Copy link
Contributor

@edusperoni edusperoni commented Jun 16, 2021

PR Checklist

What is the current behavior?

On an edge case where the rootView is not set, onSaveInstanceState will crash the app.

What is the new behavior?

No longer crashes as we check if the rootView exists before using it.

Fixes NativeScript/angular#8.

@cla-bot cla-bot bot added the cla: yes label Jun 16, 2021
@edusperoni edusperoni requested a review from NathanWalker Jun 16, 2021
@NathanWalker NathanWalker added this to the 8.1 milestone Jul 12, 2021
@NathanWalker NathanWalker changed the base branch from master to release/8.1.0 Aug 11, 2021
@NathanWalker NathanWalker merged commit ee3c4c2 into release/8.1.0 Aug 11, 2021
3 checks passed
@NathanWalker NathanWalker deleted the fix/null-rootView branch Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants