C++: Introduce a pre-SSA DataFlow::Node class#11541
Merged
MathiasVP merged 2 commits intoDec 6, 2022
Merged
Conversation
jketema
approved these changes
Dec 6, 2022
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
Two small comments to help my understanding. Otherwise LGTM.
|
|
||
| override Declaration getEnclosingCallable() { result = this.getFunction() } | ||
|
|
||
| override Declaration getFunction() { result = op.getUse().getEnclosingFunction() } |
Contributor
There was a problem hiding this comment.
Is there a particular reason for picking getUse here, and got getDef? I suspect it doesn't matter much either way.
Contributor
Author
There was a problem hiding this comment.
No, that shouldn't matter. I hope the definition and the use of an operand has the same enclosing function. Otherwise, I think we're dealing with a very inconsistent DB 😱.
Contributor
There was a problem hiding this comment.
Good. getDef would make slightly more sense to me, but that's just nitpicking, so I'll leave it to you whether to change it or not.
MathiasVP
merged commit e71fbb1
into
github:mathiasvp/replace-ast-with-ir-use-usedataflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple refactoring that introduces a
Nodeclass that exists before computing any SSA. This is a necessary step for my ongoing work on IR dataflow through iterators.