Experimental (ATM): update query label mappings#8605
Merged
Conversation
annarailton
force-pushed
the
annarailton/new-query-label-mappings
branch
from
1068be6 to
c6bb4e4
Compare
added 4 commits
April 8, 2022 10:22
annarailton
force-pushed
the
annarailton/new-query-label-mappings
branch
from
c6bb4e4 to
8ae905a
Compare
Contributor
|
ooi why do we need #8557 ? On the face of it the PRs are unrelated, no? |
Author
annarailton
force-pushed
the
annarailton/new-query-label-mappings
branch
from
1fa1bde to
8ae905a
Compare
henrymercer
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NotASinkTypetoNegativeTypeencoding->labelanddescription->labelNameendpointTypeEncoded->labelFixes https://github.com/github/ml-ql-adaptive-threat-modeling/issues/1819
Fixes https://github.com/github/ml-ql-adaptive-threat-modeling/issues/1820
Fixes https://github.com/github/ml-ql-adaptive-threat-modeling/issues/1821
Fixes https://github.com/github/ml-ql-adaptive-threat-modeling/issues/1816
PR in
backend: https://github.com/github/ml-ql-adaptive-threat-modeling-backend/pull/1270Requires rebasing on
#8557#8597 for the tests to all pass.