Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traduccion asyncio runner #2209

Merged
merged 22 commits into from Dec 12, 2022
Merged

Traduccion asyncio runner #2209

merged 22 commits into from Dec 12, 2022
+90 −16

Conversation

aandrea
Copy link
Contributor

@aandrea aandrea commented Nov 17, 2022 •
edited by cmaureir

Closes #1963

cmaureir
cmaureir requested changes Nov 20, 2022
View changes
Copy link
Sponsor Collaborator

@cmaureir cmaureir left a comment

Creo que se pasó otra traducción, de pdb.po.
Esto por lo general ocurre cuando comienzas una rama nueva a partir de otra antigua. Lo ideal es siempre volver a la rama principal, en este caso 3.11 antes de crear una rama nueva.

library/asyncio-runner.po Outdated Show resolved Hide resolved
@aandrea
Copy link
Contributor Author

aandrea commented Nov 22, 2022

Mil gracias, @cmaureir , me di cuenta pero no logré corregirlo, te parece que anule este pull request y comience de nuevo?

@cmaureir
Copy link
Sponsor Collaborator

cmaureir commented Nov 24, 2022

Hola @aandrea 👋 ahí lo quité del PR.
En el futuro, si te pasa algo así, lo único que hay que hacer es : git checkout origin/3.11 -- library/pdb.po luego haces un commit y push al mismo PR.

cmaureir
cmaureir reviewed Nov 24, 2022
View changes
library/asyncio-runner.po Outdated Show resolved Hide resolved
@cmaureir
Copy link
Sponsor Collaborator

cmaureir commented Nov 24, 2022

tu comentario aún dice 'work in progress' es así? o lo terminaste? :O

@aandrea
Copy link
Contributor Author

aandrea commented Nov 24, 2022

Hola @cmaureir ! Mil gracias por la ayuda! Quería corregir unos detalles de estilo y estaría.

@cmaureir
Copy link
Sponsor Collaborator

cmaureir commented Dec 2, 2022

¿te parece si hacemos el merge @aandrea ?

rtobar
rtobar reviewed Dec 4, 2022
View changes
Copy link
Collaborator

@rtobar rtobar left a comment

Hola! Un par de sugerencias después de una miradita rapida

library/asyncio-runner.po Outdated Show resolved Hide resolved
library/asyncio-runner.po Outdated Show resolved Hide resolved
library/asyncio-runner.po Outdated Show resolved Hide resolved
library/asyncio-runner.po Outdated Show resolved Hide resolved
library/asyncio-runner.po Outdated Show resolved Hide resolved
library/asyncio-runner.po Outdated Show resolved Hide resolved
library/asyncio-runner.po Outdated Show resolved Hide resolved
library/asyncio-runner.po Outdated Show resolved Hide resolved
library/asyncio-runner.po Outdated Show resolved Hide resolved
library/asyncio-runner.po Outdated Show resolved Hide resolved
@aandrea
Copy link
Contributor Author

aandrea commented Dec 9, 2022

Hola @cmaureir , tuve un par de contratiempos personales, agrego los comentarios de @rtobar y termino. Mil disculpas por la demora

aandrea and others added 7 commits Dec 9, 2022
@aandrea
Merge branch '3.11' into traduccion-asyncio-runner
f73d381
@aandrea @rtobar
Update library/asyncio-runner.po
861d3df 
typo ->cuidado

Co-authored-by: rtobar <rtobarc@gmail.com>
@aandrea @rtobar
Update library/asyncio-runner.po
986562a 
typo -> respetar

Co-authored-by: rtobar <rtobarc@gmail.com>
@aandrea @rtobar
Update library/asyncio-runner.po
9df1e42 
typo -> lanzada

Co-authored-by: rtobar <rtobarc@gmail.com>
@aandrea @rtobar
Update library/asyncio-runner.po
c12a2f9 
typo -> e

Co-authored-by: rtobar <rtobarc@gmail.com>
@aandrea @rtobar
Update library/asyncio-runner.po
5102f5e 
typo -> desenvuelva

Co-authored-by: rtobar <rtobarc@gmail.com>
@aandrea @rtobar
Update library/asyncio-runner.po
0b58a0f 
typo -> lanzado

Co-authored-by: rtobar <rtobarc@gmail.com>
@cmaureir
Copy link
Sponsor Collaborator

cmaureir commented Dec 9, 2022

Hola @cmaureir , tuve un par de contratiempos personales, agrego los comentarios de @rtobar y termino. Mil disculpas por la demora

nada de que disculparse, es solo para saber si en algún momento nos tenemos que encargar de finalizar el pull request. Ánimo y sin presiones :)

@aandrea
Copy link
Contributor Author

aandrea commented Dec 10, 2022

Gracias @cmaureir y @rtobar por la ayuda y las sugerencias, ahí debería estar mejor :)

@aandrea aandrea requested review from cmaureir and rtobar and removed request for cmaureir and rtobar Dec 10, 2022
@cmaureir cmaureir merged commit dc9e0c2 into python:3.11 Dec 12, 2022
2 checks passed
@cmaureir
Copy link
Sponsor Collaborator

cmaureir commented Dec 12, 2022

gracias! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtobar rtobar

@cmaureir cmaureir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate 'library/asyncio-runner.po'
3 participants
@aandrea @cmaureir @rtobar