Skip to content

fix(@angular-devkit/build-angular): ensure correct SRI values with differential loading#19093

Merged
alan-agius4 merged 1 commit into
angular:masterfrom
clydin:fix-sri-dl
Oct 16, 2020
Merged

fix(@angular-devkit/build-angular): ensure correct SRI values with differential loading#19093
alan-agius4 merged 1 commit into
angular:masterfrom
clydin:fix-sri-dl

Conversation

@clydin

@clydin clydin commented Oct 15, 2020

Copy link
Copy Markdown
Member

Previously, the cached integrity values for a subsequent differential loading build would not be properly integrated. This resulted in builds with incorrect integrity values after an initial build. The cached differential loading builds will now use the correct integrity values on subsequent builds.

Closes #18254

@clydin clydin added the target: patch This PR is targeted for the next patch release label Oct 15, 2020
@google-cla google-cla Bot added the cla: yes label Oct 15, 2020
@clydin clydin requested a review from alan-agius4 October 15, 2020 23:35
…fferential loading

Previously, the cached integrity values for a subsequent differential loading build would not be properly integrated.  This resulted in builds with incorrect integrity values after an initial build.  The cached differential loading builds will now use the correct integrity values on subsequent builds.

Closes angular#18254
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 16, 2020
@alan-agius4 alan-agius4 merged commit eac9e99 into angular:master Oct 16, 2020
@clydin clydin deleted the fix-sri-dl branch October 16, 2020 10:36
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subresource Integrity for lazy modules is broken when DL is enabled and built twice

2 participants