Refine 'gaining commit privileges'.#969
Merged
ezio-melotti merged 10 commits intopython:mainfrom Dec 25, 2022
Merged
Conversation
- Allow the audience to be anybody (not just an individual seeking commit privileges). Avoids use of second-person language. - Provide guidance for all involved. - Refer to the various actors directly, avoiding passive language. Use 'candidate', 'submitter', and 'approver' to represent the key actors. - Move the "cross-post" action into step 1 to indicate better the temporal positition of the action. - Summarize the confirmation criterion (2/3 vote) rather than make the reader go to the PEP, which basically indicates 2/3 vote. - Include the steering council email, because the submitter may not know it. - Normalize the initial approver actions. Previously, council was directed to be "asking for ... a reminder about the Code of Conduct and to report issues to the PSF WG". Now it's two requests and a reminder. - Hyperlink "python/voters" instead of the full URL.
hugovk
reviewed
Nov 18, 2022
| (approver) will email the candidate: | ||
|
|
||
| - A request for account details as required by | ||
| `🔒 python/voters <https://github.com/python/voters>`_ |
Member
There was a problem hiding this comment.
This "🔒 python/voters" contraction looks good 👍
GitHub does similar: https://github.com/python/voters
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
CAM-Gerlach
reviewed
Dec 16, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
A couple final small grammar and clarity tweaks, otherwise LGTM. Thanks @jaraco , this is a big improvement IMO!
|
|
||
| #. Once the candidate has provided the pertinent details, the approver will: | ||
|
|
||
| - enable various new privileges; |
Member
There was a problem hiding this comment.
Ideally, this would be a bit more specific, although I guess approvers are assumed to be sufficiently experienced to just know this information...
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During my recent experience nominating someone for commit privileges, I ran into some friction attempting to follow the guidance. This change addresses that friction.