Remove a redundant assignment in Tools/unittestgui/unittestgui.py #21438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shidenko97
changed the title
__rollbackImporter in BaseGUITestRunner__rollbackImporter in BaseGUITestRunner [skip issue]
shidenko97
changed the title
__rollbackImporter in BaseGUITestRunner [skip issue]__rollbackImporter in BaseGUITestRunner [skip issue, skip news]
eamanu
approved these changes
Jul 11, 2020
There was a problem hiding this comment.
Hi! Good catch @shidenko97 LGTM.
IMO is very simple change, and I'm curious why this line is there.
iritkatriel
changed the title
__rollbackImporter in BaseGUITestRunner [skip issue, skip news]
iritkatriel
added
needs backport to 3.9
|
closing and reopening to get a current test run. |
iritkatriel
approved these changes
May 16, 2021
|
This probably needs to be rebased. |
@iritkatriel Main merged to current branch |
|
Thanks @shidenko97 for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 16, 2021
…thonGH-21438) (cherry picked from commit a42d98e) Co-authored-by: Serhii Hidenko <shidenko97@gmail.com>
|
GH-26168 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 16, 2021
…thonGH-21438) (cherry picked from commit a42d98e) Co-authored-by: Serhii Hidenko <shidenko97@gmail.com>
|
GH-26169 is a backport of this pull request to the 3.9 branch. |
iritkatriel
pushed a commit
that referenced
this pull request
May 16, 2021
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
May 16, 2021
….py (pythonGH-21438) (cherry picked from commit a42d98e) Co-authored-by: Serhii Hidenko <shidenko97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just removed duplicated defining an attribute
__rollbackImporterin classBaseGUITestRunner, moduleunittestgui. It's not important, but Python code should be clear.Automerge-Triggered-By: GH:iritkatriel