Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38610: Fix possible crashes in several list methods #17022

Merged
merged 3 commits into from Dec 30, 2019
Merged

bpo-38610: Fix possible crashes in several list methods #17022

merged 3 commits into from Dec 30, 2019

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Oct 31, 2019 •
edited by bedevere-bot

Hold strong references to list elements while calling
PyObject_RichCompareBool().

https://bugs.python.org/issue38610

@ZackerySpytz
bpo-38610: Fix possible crashes in several list methods
a4493c4 
Hold strong references to list elements while calling
PyObject_RichCompareBool().
shihai1991
shihai1991 reviewed Nov 3, 2019
View changes
Objects/listobject.c Show resolved Hide resolved
@ZackerySpytz ZackerySpytz mentioned this pull request Dec 30, 2019
Merged
pablogsal
pablogsal approved these changes Dec 30, 2019
View changes
Copy link
Member

@pablogsal pablogsal left a comment

LGTM

Lib/test/test_list.py Outdated Show resolved Hide resolved
@pablogsal pablogsal merged commit d9e561d into python:master Dec 30, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Dec 30, 2019

Thanks @ZackerySpytz for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@pablogsal
Copy link
Member

pablogsal commented Dec 30, 2019

Thanks @ZackerySpytz for the quick fix!

@bedevere-bot
Copy link

bedevere-bot commented Dec 30, 2019

GH-17758 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Dec 30, 2019

Sorry, @ZackerySpytz and @pablogsal, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d9e561d23d994e3ed15f4fcbd7ee5c8fe50f190b 3.7

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Dec 30, 2019
@ZackerySpytz @pablogsal
[3.7] bpo-38610: Fix possible crashes in several list methods (python…
f8679b1 
…GH-17022)

Hold strong references to list elements while calling PyObject_RichCompareBool()..
(cherry picked from commit d9e561d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 30, 2019

GH-17759 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Dec 30, 2019
@miss-islington @ZackerySpytz
bpo-38610: Fix possible crashes in several list methods (GH-17022)
fcaf14c 
Hold strong references to list elements while calling PyObject_RichCompareBool().
(cherry picked from commit d9e561d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
pablogsal added a commit that referenced this pull request Dec 30, 2019
@pablogsal @ZackerySpytz
[3.7] bpo-38610: Fix possible crashes in several list methods (GH-17022…
296d45e 
…) (GH-17759)

Hold strong references to list elements while calling PyObject_RichCompareBool()..
(cherry picked from commit d9e561d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
corona10 pushed a commit to corona10/cpython that referenced this pull request Jan 27, 2020
@ZackerySpytz @corona10
bpo-38610: Fix possible crashes in several list methods (pythonGH-17022)
cf7cdaa 
Hold strong references to list elements while calling PyObject_RichCompareBool().
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ZackerySpytz @shihai1991
bpo-38610: Fix possible crashes in several list methods (pythonGH-17022)
720d56f 
Hold strong references to list elements while calling PyObject_RichCompareBool().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihai1991 shihai1991

@pablogsal pablogsal

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ZackerySpytz @miss-islington @pablogsal @bedevere-bot @shihai1991 @the-knights-who-say-ni