Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41224: Document is_annotated() in symtable module and update doc strings #21369

Merged
merged 2 commits into from Jul 7, 2020

Conversation

nanjekyejoannah
Copy link
Member

@nanjekyejoannah nanjekyejoannah commented Jul 7, 2020

This PR does the following:

  • Documents is_annotated() in the symtable module.
  • Adds docstrings to the functions that did not already have them.

https://bugs.python.org/issue41224

Lib/symtable.py Outdated Show resolved Hide resolved
Copy link
Member

@pablogsal pablogsal left a comment

LGTM

Thanks @nanjekyejoannah for the improvements :)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@nanjekyejoannah nanjekyejoannah changed the title bpo-41224: Document is_annotate() in symtable module and update doc strings bpo-41224: Document is_annotated() in symtable module and update doc strings Jul 7, 2020
@nanjekyejoannah nanjekyejoannah merged commit a95ac77 into python:master Jul 7, 2020
4 checks passed
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
…strings (pythonGH-21369)

* Document is_annotate() and update doc strings

* Move quotes to the next line.

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
…strings (pythonGH-21369)

* Document is_annotate() and update doc strings

* Move quotes to the next line.

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Sorry, @nanjekyejoannah, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a95ac779e6bca0d87819969e361627182b83292c 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Sorry @nanjekyejoannah, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a95ac779e6bca0d87819969e361627182b83292c 3.9

@andresdelfino
Copy link
Contributor

andresdelfino commented Dec 30, 2020

PRs #24016 and #24017 resolves what's asked here (the backports). Not sure if commit a95ac77 should be cherry picked, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants