fix(core): type collisions with namespace#8809
Merged
NathanWalker merged 14 commits intofix/feature-cleanupfrom Feb 26, 2021
Merged
fix(core): type collisions with namespace#8809NathanWalker merged 14 commits intofix/feature-cleanupfrom
NathanWalker merged 14 commits intofix/feature-cleanupfrom
Conversation
9d6e694 to
689f2b1
Compare
8753605 to
86395da
Compare
6f862a7 to
083e696
Compare
d4ced42 to
53488b5
Compare
1cb2fee to
fcbecd1
Compare
b26f471 to
aa7161e
Compare
aa7161e to
11155c2
Compare
Contributor
Author
|
This has been published as an |
b286d51 to
a2896c9
Compare
NathanWalker
added a commit
that referenced
this pull request
Feb 27, 2021
NathanWalker
added a commit
that referenced
this pull request
Feb 27, 2021
NathanWalker
added a commit
that referenced
this pull request
Mar 3, 2021
NathanWalker
added a commit
that referenced
this pull request
Mar 5, 2021
NathanWalker
added a commit
that referenced
this pull request
Mar 30, 2021
NathanWalker
added a commit
that referenced
this pull request
Mar 30, 2021
NathanWalker
added a commit
that referenced
this pull request
Apr 2, 2021
NathanWalker
added a commit
that referenced
this pull request
Apr 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Currently while using
import { Enums } from '@nativescript/core';in es2017 there was no clear way to delineate betweentypedefinition andnamespace/moduleas they were overloaded throughout.There was a workaround that you could do:
...but that's pretty inconvenient.
Also the barrel was missing a few ui property getter/setters for plugin usage.
What is the new behavior?
Typehas been added to suffix any exportedtypenamed symbols for better clarity and usage while allowing thenamespace/moduleto work as normal as well.This also adds the additional getter/setters for plugin usage:
/cc @PeterStaev