Skip to content

feat(core): added testID for Detox e2e testing (#8943)#8944

Closed
keerl wants to merge 1 commit into
NativeScript:masterfrom
keerl:feature/detox_test_id
Closed

feat(core): added testID for Detox e2e testing (#8943)#8944
keerl wants to merge 1 commit into
NativeScript:masterfrom
keerl:feature/detox_test_id

Conversation

@keerl
Copy link
Copy Markdown

@keerl keerl commented Oct 6, 2020

PR Checklist

What is the current behavior?

On Android, the current automationText sets the content description but not the tag. Detox uses the content description as by.label() and a tag as by.id(). There is currently no built-in way to use by.id() (on Android at least).

What is the new behavior?

Implements #8943.

Adds the testID property which uses setTag() on Android and accessibilityIdentifier on iOS.

testID can be used for Detox's by.id() and automationText can be used for Detox's by.label().

@keerl
Copy link
Copy Markdown
Author

keerl commented Oct 21, 2020

I am deciding to close this PR in favor of waiting for #8909 to be merged. It will incorporate a accessibilityIdentifier and accessibilityLabel which will correspond with Detox's by.id() and by.label() respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant