You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change the title of the PR to something like: bpo-24147: Document csv Dialect class defaults. Patch by Brandon Milam.
uniocto
changed the title
bpo-24147: Apply Brandon Milam's patch about csv doc
bpo-24147: Document csv Dialect class defaults. Patch by Brandon Milam.
May 8, 2021
uniocto
changed the title
bpo-24147: Document csv Dialect class defaults. Patch by Brandon Milam.
bpo-24147: Document csv Dialect class defaults. Patch by Brandon Milam
May 8, 2021
Doesn't compile:
fix-issue-24147 $… make -C Doc/ html
make: Entering directory '/home/me/Documents/GitHub/cpython/Doc'
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
PATH=./venv/bin:$PATH sphinx-build -b html -d build/doctrees -W . build/html
Running Sphinx v4.5.0
loading pickled environment... done
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 487 source files that are out of date
updating environment: 0 added, 447 changed, 2 removed
reading sources... [100%] whatsnew/index Warning, treated as error:
/home/me/Documents/GitHub/cpython/Doc/c-api/complex.rst:49:Error in declarator or parameters
Error in declarator or parameters
Invalid C declaration: Expected identifier, got user-defined keyword: complex. Remove it from c_extra_keywords to allow it as identifier.
Currently c_extra_keywords is ['alignas', 'alignof', 'bool', 'complex', 'imaginary', 'noreturn', 'static_assert', 'thread_local']. [error at 39]
Py_complex _Py_c_neg(Py_complex complex)
make: *** [Makefile:51: build] Error 2
make: Leaving directory '/home/me/Documents/GitHub/cpython/Doc'
The target is Python 2, would it be possible to re-target on the latest version?
The CSV Doc hasn't changed so still relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue24147