Skip to content

gh-84853: Use Argument Clinic for csv (where possible) #20200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2022
Merged

gh-84853: Use Argument Clinic for csv (where possible) #20200

merged 1 commit into from
Apr 16, 2022

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented May 19, 2020 •
edited by bedevere-bot
Loading

JelleZijlstra
JelleZijlstra reviewed Feb 14, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Modules/_csv.c Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Return a list of all know dialect names.
Return a list of all known dialect names.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, although I'll note that the error was extant (I can revert the typo fix if someone feels that's a problem).

Modules/_csv.c Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this doesn't say str because we need the PyObject inside the function. Any way we can still get the __text_signature__ more precise?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I'm aware of (within Argument Clinic and without changing some csv.Errors to TypeErrors)

@JelleZijlstra JelleZijlstra self-assigned this Apr 13, 2022
@ghost
Copy link

ghost commented Apr 13, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@JelleZijlstra JelleZijlstra changed the title bpo-40676: Use Argument Clinic for csv (where possible) gh-84853: Use Argument Clinic for csv (where possible) Apr 13, 2022
@hauntsaninja
Copy link
Contributor Author

Do I need to sign a new CLA? If so, how? (the knights who say ni were clearer on this point)

@JelleZijlstra
Copy link
Member

I think the bot wants the other bots to sign a CLA. You shouldn't have to resign.

@JelleZijlstra
Copy link
Member

Unfortunately we will have to resolve the CLA issue before we can merge. @ambv should be able to confirm, but as I understand it the bot looks at the email address in your commits (from git config user.email) and uses that as the key for the CLA check. But your commits have an empty email field:

commit 24816bd6b1a566ff942b957d2da6cc04528cb73a
Author: hauntsaninja <>
Date:   Mon May 18 18:37:19 2020 -0700

If that's the issue, then you'll have to set your user.email to whatever you used when you signed the CLA, recreate the branch with your new email set, then force push.

@hauntsaninja
Copy link
Contributor Author

hauntsaninja commented Apr 14, 2022 •
edited
Loading

Fwiw, git config user.email jelle.zijlstra@gmail.com seems to have worked :-) Is that expected / how easily deceived were the knights who say ni?

@JelleZijlstra
Copy link
Member

Would you mind setting it to your own email? I wouldn't want to take credit for your hard work.

@hauntsaninja
Copy link
Contributor Author

Okay, re-pushed. Github would have reauthored the commit when it gets squashed anyway

@JelleZijlstra JelleZijlstra merged commit 1adc837 into python:main Apr 16, 2022
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 16, 2022
Closed
@hauntsaninja hauntsaninja deleted the csv branch April 26, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hauntsaninja @JelleZijlstra @the-knights-who-say-ni @bedevere-bot