Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40645: Fix ref leaks in _hashopenssl #26079

Merged
merged 1 commit into from May 12, 2021
Merged

bpo-40645: Fix ref leaks in _hashopenssl #26079

merged 1 commit into from May 12, 2021
+9 −5

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 12, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue40645
@erlend-aasland
bpo-40645: Fix ref leaks in _hashopenssl
Verified
This commit was signed with the committer’s verified signature.
erlend-aasland Erlend Egeberg Aasland
GPG key ID: E323E17E686C7B5F Learn about vigilant mode.
Loading status checks…
e6b7fb6
@erlend-aasland erlend-aasland requested a review from tiran as a code owner May 12, 2021
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented May 12, 2021

cc. @encukou
@pablogsal
pablogsal approved these changes May 12, 2021
View changes
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented May 12, 2021

Backport to 3.10, @pablogsal ?
@erlend-aasland erlend-aasland mentioned this pull request May 12, 2021
Merged
@pablogsal
Copy link
Member

@pablogsal pablogsal commented May 12, 2021

Yup, and to any version that has this problem. Can you add the labels?
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented May 12, 2021 •
edited

Yup, and to any version that has this problem. Can you add the labels?

GH-26072 is (currently) only being backported to 3.10, so for now I'm only adding the 3.10 label. I'll check 3.9 asap and add to both PR's if necessary. BTW, #26072 needs manual backporting.

UPDATE: Seems like the code in question was added in 933dfd7. Backporting to 3.10 should be sufficient.
@pablogsal pablogsal merged commit 504ffda into python:main May 12, 2021
11 of 12 checks passed
11 of 12 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL (1.1.1k)
Details
@github-actions
Ubuntu SSL tests with OpenSSL (3.0.0-alpha16)
Details
Azure Pipelines PR #20210512.45 failed
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 40645 found
Details
@bedevere-bot
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 12, 2021

Thanks @erlend-aasland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
@erlend-aasland erlend-aasland deleted the erlend-aasland:fix-hashlib-refleaks branch May 12, 2021
miss-islington added a commit to miss-islington/cpython that referenced this pull request May 12, 2021
@erlend-aasland @miss-islington
bpo-40645: Fix ref leaks in _hashopenssl (pythonGH-26079)
983aa4c 
(cherry picked from commit 504ffda)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 12, 2021

GH-26082 is a backport of this pull request to the 3.10 branch.
@pablogsal
Copy link
Member

@pablogsal pablogsal commented May 12, 2021

Yup, and to any version that has this problem. Can you add the labels?

GH-26072 is (currently) only being backported to 3.10, so for now I'm only adding the 3.10 label. I'll check 3.9 asap and add to both PR's if necessary. BTW, #26072 needs manual backporting.

UPDATE: Seems like the code in question was added in 933dfd7. Backporting to 3.10 should be sufficient.

Fantastic. Thanks a lot for the patch 🎉
miss-islington added a commit that referenced this pull request May 12, 2021
@miss-islington @erlend-aasland
bpo-40645: Fix ref leaks in _hashopenssl (GH-26079)
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
1ee58f2 
(cherry picked from commit 504ffda)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@tiran tiran

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants
@erlend-aasland @pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni