Updating and adding missing labels on pt_BR locale#6154
Updating and adding missing labels on pt_BR locale#6154GutoVeronezi merged 18 commits intoapache:mainfrom
Conversation
|
We need someone with language expertise to review/approve this - @GabrielBrascher maybe? |
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@GutoVeronezi and/or @GabrielBrascher could you guys review this PR, thanks. |
Co-authored-by: SadiJr <sadijacinto@gmail.com>
|
Found UI changes, kicking a new UI QA build |
|
Found Java/XML changes, kicking packaging job |
|
@acs-robot a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Found UI changes, kicking a new UI QA build |
|
Found Java/XML changes, kicking packaging job |
|
@acs-robot a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
PR Coverage Report
|
1 similar comment
PR Coverage Report
|
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3201 |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3202 |
There was a problem hiding this comment.
@BryanMLima, I couldn't review all the changes yet; however, I noticed that sometimes we write the entities in capitalized and sometimes in lowercase (Armazenamento Primário/armazenamento primário, Template/template). I think we should standardize the entities written, what do you think?
cc: @GabrielBrascher, @SadiJr
edit
PR #6281 is standardizing entities in lowercase. IMHO it's better (and clean) to read than capitalized.
@GutoVeronezi in English and German they tend to overcapitalise a lot, each with their own rules. Spanish and Dutch don´t do it as much and I imagine Portuguese neither. I´d advice you to use your Portuguese or Brazilian conventions for this. |
|
UI build: ✔️ |
|
Kudos, SonarCloud Quality Gate passed!
|
GabrielBrascher
left a comment
GabrielBrascher
left a comment
There was a problem hiding this comment.
Thanks for the PR @BryanMLima.
LGTM
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Found UI changes, kicking a new UI QA build |
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@GabrielBrascher @GutoVeronezi @, can we merge this? |
|
Merging based in the approvals and test results. |
9 participants
Description
This PR aims to improve the pt_BR labels and messages to enhance the user experience. This PR adds more than a thousand lines of new labels (to PT-BR) based on the English labels.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
It was tested in a local lab changing the default the language to pt_BR and then I navigated in the ACS UI to see if there was something odd or missing.