refactor(file-structure): cleaned up sim file structure#1486
Closed
emir-karabeg wants to merge 10 commits into
Closed
refactor(file-structure): cleaned up sim file structure#1486emir-karabeg wants to merge 10 commits into
emir-karabeg wants to merge 10 commits into
Conversation
emir-karabeg
force-pushed
the
refactor/file-structure
branch
from
820517b to
539744a
Compare
waleedlatif1
force-pushed
the
staging
branch
from
f0c20a9 to
010753d
Compare
waleedlatif1
reviewed
Oct 1, 2025
| if (process.env.NEXT_RUNTIME === 'edge') { | ||
| console.log('[Main Instrumentation] Loading Edge Runtime instrumentation...') | ||
| const edgeInstrumentation = await import('./instrumentation-edge') | ||
| const edgeInstrumentation = await import('./lib/instrumentation/edge') |
Collaborator
There was a problem hiding this comment.
@emir-karabeg this might break because instrumentation runs before /lib import alias is available from tsconfig
waleedlatif1
reviewed
Oct 1, 2025
Collaborator
There was a problem hiding this comment.
these file names have to stay the way they were before, and can't be in lib/
https://nextjs.org/docs/app/guides/instrumentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleaned up Sim file structure to follow best-practices with NextJS repositories. I moved files to lib and adjusted page/component files to align best-practices.
Type of Change
Testing
No functionality changes.
Checklist