fix typo in fastsearch comments #14608
Conversation
too vs. two vs. to
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
@esc Thanks for the contribution! If you have already signed the CLA over 24 hours ago, try manually updating the status on GitHub. This can be done by clicking on the "check yourself" link posted by the CLA bot @the-knights-who-say-ni. I had to do perform this process for my CLA status to be updated, so I figured it'd be worth mentioning.
Otherwise, it looks like all of the tests are passing, and typo corrections are always welcome. Once the CLA is updated, a core developer will be able to review your PR and potentially have it merged into the repository.
|
@aeros167 thanks for pointing towards that, but I haven't actually signed it yet, will do that now. |
|
O.K. I have just signed it, now I wait. |
|
@esc No problem. After the CLA has been verified, feel free to also check out the Python bug tracker for specific issues that could use assistance: https://bugs.python.org/ I'd recommend starting with the ones under the "easy issues" category. Also, another great resource for new contributors is the dev guide: https://devguide.python.org/ |
|
Alright, CLA is signed, what next? |
Next, we just have to wait for a core python developer to check out the PR. Usually it takes no longer than a week or so depending on how busy they are. They have to provide the final "stamp of approval" in order for it to be auto-merged into the CPython repository. Since this is a minor change, they'll probably add the |
|
@mangrisano great! What do I need to do next to get this merged! |
|
You need to wait for a core-dev. |
As I had said a bit earlier:
The changes can't be merged until a core dev approves them. On average, this usually takes around a week or two, but can take longer depending on how busy they are. For more information, see the devguide. I'd recommend reading over the pull request page, but the "Review" section in particular is the most relevant to your question. |
|
Thanks @esc for the PR, and @matrixise for merging it |
(cherry picked from commit 60bba83) Co-authored-by: Valentin Haenel <esc@users.noreply.github.com>
|
GH-15933 is a backport of this pull request to the 3.8 branch. |
|
Thank you for your contribution, your PR has been merged into master and will be backported to 3.8. |
too vs. two vs. to