[3.10] gh-91401: Conservative backport of subprocess._USE_VFORK
#91932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not alter the `_posixsubprocess.fork_exec()` private API to avoid issues for anyone relying on that (bad idea) or for anyone who's `subprocess.py` and `_posixsubprocess.so` upgrades may not become visible to existing Python 3.10 processes at the same time. Backports the concept of cd5726f.
gpshead
added
type-bug
Other tests obviously have this case covered.
Moves the allow_vfork checks into a stanza before the existing setsig stuff. Avoids reindenting existing code.
izbyshev
reviewed
May 1, 2022
izbyshev
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not alter the
_posixsubprocess.fork_exec()private API toavoid issues for anyone relying on that (bad idea) or for anyone who's
subprocess.pyand_posixsubprocess.soupgrades may not becomevisible to existing Python 3.10 processes at the same time.
Backports the concept of cd5726f.
Provides a fail-safe way to disable vfork for #91401.
I didn't backport the documentation as I don't actually expect this to be used and versionadded 3.10.5 always looks weird in docs. It's being done more to have a fail-safe in place for people just in case.