Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91915: Fix test_netrc on non-UTF-8 locale #91918

Merged
merged 1 commit into from Apr 26, 2022
Merged

gh-91915: Fix test_netrc on non-UTF-8 locale #91918

merged 1 commit into from Apr 26, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 25, 2022

Closes #91915.

@serhiy-storchaka serhiy-storchaka merged commit 36306cf into python:main Apr 26, 2022
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Apr 26, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 26, 2022

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 36306cf7862097318a3fef74224075cc4cf37229 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Apr 26, 2022

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 36306cf7862097318a3fef74224075cc4cf37229 3.9

@serhiy-storchaka serhiy-storchaka deleted the test_netrc branch Apr 26, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 26, 2022
@serhiy-storchaka
[3.10] pythongh-91915: Fix test_netrc on non-UTF-8 locale (pythonGH-9…
cffd470 
…1918).

(cherry picked from commit 36306cf)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 26, 2022

GH-91946 is a backport of this pull request to the 3.10 branch.

@serhiy-storchaka serhiy-storchaka removed their assignment Apr 26, 2022
serhiy-storchaka added a commit that referenced this pull request Apr 26, 2022
@serhiy-storchaka
[3.10] gh-91915: Fix test_netrc on non-UTF-8 locale (GH-91918). (GH-9…
dbe666d 
…1946)

(cherry picked from commit 36306cf)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_netrc fails on non-UTF-8 locale
3 participants
@serhiy-storchaka @miss-islington @bedevere-bot