Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP - width aware output take 2 #731
Closed
Conversation
|
A requirement for merging this should be identifying exactly what it's fixing. I had thought it might be fixing issues like #670 but that has to do with terminal escapes - this is really only a unicode fix. |
|
Another issue: |
|
Not entirely sure but could you, while you're in this part of the code, see if this also gets resolved: #724 with the patches? |
|
@rybarczykj knows where this is if we work on this more, I'm closing because even if we do this it won't be with this PR. |
This was referenced Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
thomasballinger commentedFeb 13, 2018
•
edited
The Curtsies version referenced does not exist yet, don't merge.
Perf looks better now, a linear 10x slower. Wonder if this is good enough, I made some guesses about how to make things fast in bpython/curtsies#109 but haven't profiled at all.