fix(compiler-cli): ensure HMR works with different output module type #60797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when we transpile the HMR update module, we use the project's compiler options verbatim. This appears to break down with some module types, whereas we have to use a native export. These changes override the compiler options to ensure that the user's options don't end up breaking HMR. Fixes angular#60795.
crisbeto
added
action: review
angular-robot
bot
added
the
area: compiler
azimtechie
approved these changes
Apr 9, 2025
clydin
approved these changes
Apr 9, 2025
crisbeto
added
action: merge
atscott
pushed a commit
that referenced
this pull request
Apr 9, 2025
…#60797) Currently when we transpile the HMR update module, we use the project's compiler options verbatim. This appears to break down with some module types, whereas we have to use a native export. These changes override the compiler options to ensure that the user's options don't end up breaking HMR. Fixes #60795. PR Close #60797
|
This PR was merged into the repository by commit 8744c9a. The changes were merged into the following branches: main, 19.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we transpile the HMR update module, we use the project's compiler options verbatim. This appears to break down with some module types, whereas we have to use a native export.
These changes override the compiler options to ensure that the user's options don't end up breaking HMR.
Fixes #60795.