refactor(core): add ApplicationRef.prototype.bootstrapImpl with injector parameter
#60622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgp1130
added
action: review
dgp1130
force-pushed
the
app-ref-injector
branch
from
f3bd739 to
54baf5a
Compare
dgp1130
changed the title
injector parameter to ApplicationRef.prototype.bootstrapApplicationRef.prototype.ɵbootstrap with injector parameter
dgp1130
force-pushed
the
app-ref-injector
branch
from
54baf5a to
a520ef6
Compare
dgp1130
changed the title
ApplicationRef.prototype.ɵbootstrap with injector parameterApplicationRef.prototype.bootstrapImpl with injector parameter
dgp1130
force-pushed
the
app-ref-injector
branch
from
a520ef6 to
bd0e458
Compare
AndrewKushnir
approved these changes
Apr 1, 2025
AndrewKushnir
removed
the
action: review
dgp1130
added
target: patch
thePunderWoman
pushed a commit
that referenced
this pull request
Apr 1, 2025
…`injector` parameter (#60622) This allows any components individually bootstrapped to inherit from a unique `Injector`. This is useful when bootstrapping multiple root components with different providers. For now, the function is private while we explore potential designs to consolidate it with the existing `ApplicationRef.prototype.bootstrap` method. PR Close #60622
|
This PR was merged into the repository by commit 7cb8639. The changes were merged into the following branches: main, 19.2.x |
thePunderWoman
added a commit
to thePunderWoman/angular
that referenced
this pull request
Apr 1, 2025
…with an `injector` parameter (angular#60622)" This reverts commit 7cb8639.
thePunderWoman
added a commit
that referenced
this pull request
Apr 1, 2025
thePunderWoman
added a commit
that referenced
this pull request
Apr 1, 2025
thePunderWoman
added
action: cleanup
|
@dgp1130 We unfortunately had to revert this. The test is broken post merge. The failure was that the |
|
@jessicajaniuk can you link me to the test failure? Not sure what would be going on here post-merge that would cause a failure. |
|
@dgp1130 I think you'll see it if you rebase first. Can you give that a try? |
dgp1130
added a commit
to dgp1130/angular
that referenced
this pull request
Apr 1, 2025
… with an `injector` parameter (angular#60622)" (angular#60669) This reverts commit d5a8a1c.
dgp1130
force-pushed
the
app-ref-injector
branch
from
bd0e458 to
5c2248f
Compare
dgp1130
added a commit
to dgp1130/angular
that referenced
this pull request
Apr 2, 2025
… with an `injector` parameter (angular#60622)" (angular#60669) This reverts commit d5a8a1c.
dgp1130
force-pushed
the
app-ref-injector
branch
from
5c2248f to
d49590d
Compare
…`injector` parameter This is a roll forward of commit d5a8a1c. Nothing is meaningfully different, as we're trying again to see if the CI failure is reproducible.
dgp1130
force-pushed
the
app-ref-injector
branch
from
d49590d to
da970d1
Compare
dgp1130
added
action: merge
|
This PR was merged into the repository by commit 2348f26. The changes were merged into the following branches: main, 19.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows any components individually bootstrapped to inherit from a unique
Injector. This is useful when bootstrapping multiple root components with different providers.Blocking cl/741690539.