Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add panelTitleBadge color variables #240645

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Add panelTitleBadge color variables #240645

merged 4 commits into from
Feb 18, 2025

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Feb 13, 2025

Add new panelTitleBadge.background and panelTitleBadge.foreground color variables to allow for more user customization. Use the defaults colors from activityBarBadge.

Fixes #240510

/CC @benibenj

@meganrogge meganrogge assigned benibenj and unassigned meganrogge Feb 13, 2025
benibenj
benibenj requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@benibenj benibenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. I suggested some changes. It would be nicer if the panel colors you added would use the activity bar colors as default color. Also, I don't think we need/should make any changes to the built in themes

@cdce8p cdce8p requested a review from benibenj February 17, 2025 09:08
benibenj
benibenj approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@benibenj benibenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, works great!

@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 17, 2025
@cdce8p
Copy link
Contributor Author

cdce8p commented Feb 17, 2025

A few workflow runs are still awaiting approval. Would be awesome if someone could click that button.

@cdce8p
Copy link
Contributor Author

cdce8p commented Feb 18, 2025

A few workflow runs are still awaiting approval. Would be awesome if someone could click that button.

Thanks! Looks like everything is green now.

@benibenj benibenj merged commit 883e882 into microsoft:main Feb 18, 2025
7 checks passed
@cdce8p cdce8p deleted the color-panel-title-badge branch February 18, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@benibenj benibenj benibenj approved these changes

Assignees

@benibenj benibenj

Labels
None yet
Projects
None yet
Milestone
February 2025
Development

Successfully merging this pull request may close these issues.

Custom color theme variable for panel title badges
4 participants
@cdce8p @DonJayamanne @benibenj @meganrogge