New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: deprecate passing `args` to `spawn` and `execFile` #57389

Merged

aduh95 merged 4 commits into nodejs:main from aduh95:spawn-args

Mar 19, 2025

+17 −0

Contributor

aduh95 commented Mar 9, 2025

Refs: #57199


          doc: deprecate passing args to spawn and execFile

cc3dfe6

nodejs-github-bot added deprecations doc labels

jasnell reviewed

View reviewed changes

doc/api/deprecations.md Outdated Show resolved Hide resolved

jasnell approved these changes

View reviewed changes

jazelly approved these changes

View reviewed changes

doc/api/deprecations.md Outdated Show resolved Hide resolved

UlisesGascon approved these changes

View reviewed changes

Contributor

DanielVenable commented Mar 11, 2025

The lint error can be fixed with the same change as used here: c885d04

lpinca approved these changes

View reviewed changes

DanielVenable reviewed

View reviewed changes

Contributor

DanielVenable left a comment

Add these lines to fix CI lint failure:

[`child_process.execFile`]: child_process.md#child_processexecfilefile-args-options-callback
[`child_process.spawn`]: child_process.md#child_processspawncommand-args-options

Contributor

mohd-akram commented Mar 18, 2025

Any update on this?

aduh95 and others added 2 commits

March 18, 2025 11:39


          Update doc/api/deprecations.md

63f2d21

Co-authored-by: James M Snell <jasnell@gmail.com>


          Update deprecations.md

f2e2ee7

aduh95 commented

View reviewed changes

doc/api/deprecations.md Outdated Show resolved Hide resolved


          Update doc/api/deprecations.md

923d349

aduh95 added the author ready label

aduh95 merged commit 109c817 into nodejs:main

18 checks passed

Contributor Author

aduh95 commented Mar 19, 2025

Landed in 109c817

aduh95 deleted the spawn-args branch

March 19, 2025 10:02

This was referenced Mar 19, 2025

doc: add history entry for DEP0190 in child_process.md #57544

Merged

doc: remove deprecated pattern in child_process.md #57568

Merged

nodejs-github-bot pushed a commit that referenced this pull request


          doc: remove deprecated pattern in child_process.md

417eecf

Co-authored-by: = <daniel.venable@proton.me>
PR-URL: #57568
Refs: #57389
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot pushed a commit that referenced this pull request


          doc: add history entry for DEP0190 in child_process.md

a46af03

PR-URL: #57544
Refs: #57389
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

aduh95 added a commit that referenced this pull request


          doc: deprecate passing args to spawn and execFile

176d951

PR-URL: #57389
Refs: #57199
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

aduh95 added a commit that referenced this pull request


          doc: remove deprecated pattern in child_process.md

c21068b

Co-authored-by: = <daniel.venable@proton.me>
PR-URL: #57568
Refs: #57389
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 added a commit that referenced this pull request


          doc: add history entry for DEP0190 in child_process.md

c45894f

PR-URL: #57544
Refs: #57389
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

github-actions bot mentioned this pull request

2025-03-31, Version 23.11.0 (Current) #57694

Merged

RafaelGSS pushed a commit that referenced this pull request


          doc: deprecate passing args to spawn and execFile

b84826a

PR-URL: #57389
Refs: #57199
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS pushed a commit that referenced this pull request


          doc: remove deprecated pattern in child_process.md

1ea6cb2

Co-authored-by: = <daniel.venable@proton.me>
PR-URL: #57568
Refs: #57389
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

RafaelGSS pushed a commit that referenced this pull request


          doc: add history entry for DEP0190 in child_process.md

98a3cd1

PR-URL: #57544
Refs: #57389
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

RafaelGSS pushed a commit that referenced this pull request


          doc: deprecate passing args to spawn and execFile

78a71d4

PR-URL: #57389
Refs: #57199
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

RafaelGSS pushed a commit that referenced this pull request


          doc: remove deprecated pattern in child_process.md

cc1e328

Co-authored-by: = <daniel.venable@proton.me>
PR-URL: #57568
Refs: #57389
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

RafaelGSS pushed a commit that referenced this pull request


          doc: add history entry for DEP0190 in child_process.md

8b8cdf7

PR-URL: #57544
Refs: #57389
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DanielVenable DanielVenable left review comments

jasnell jasnell approved these changes

lpinca lpinca approved these changes

UlisesGascon UlisesGascon approved these changes

jazelly jazelly approved these changes

Labels

author ready deprecations doc