Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DeprecationWarning in Python3.7 #152

Merged
merged 2 commits into from Sep 27, 2018

Conversation

@JoseKilo
Copy link
Contributor

@JoseKilo JoseKilo commented Sep 27, 2018

Avoid some DeprecationWarnings when using Python 3.7

Ref: python/cpython#5460
Ref: https://bugs.python.org/issue25988

Note: the latest version of pyzmq breaks the build. It's not related to this change.

@JoseKilo JoseKilo force-pushed the JoseKilo:fix/deprecation-warning-37 branch from 7fd8d8b to 9aea0e1 Sep 27, 2018
@codecov
Copy link

@codecov codecov bot commented Sep 27, 2018

Codecov Report

Merging #152 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage    92.4%   92.41%   +<.01%     
==========================================
  Files          14       14              
  Lines        1633     1634       +1     
  Branches      271      271              
==========================================
+ Hits         1509     1510       +1     
  Misses        101      101              
  Partials       23       23
Impacted Files Coverage Δ
aiozmq/rpc/pubsub.py 100% <100%> (ø) ⬆️
aiozmq/core.py 97.93% <100%> (ø) ⬆️
aiozmq/selector.py 96.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff53bf...9aea0e1. Read the comment docs.

@JelleZijlstra JelleZijlstra merged commit 8b4a9b9 into aio-libs:master Sep 27, 2018
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 92.4%)
Details
codecov/project 92.41% (+<.01%) compared to 9ff53bf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JelleZijlstra
Copy link
Collaborator

@JelleZijlstra JelleZijlstra commented Sep 27, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.