Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix styling of a link which was producing poor visibility in dark mode. #60037

Closed
wants to merge 1 commit into from
Closed

docs: Fix styling of a link which was producing poor visibility in dark mode. #60037

wants to merge 1 commit into from

Conversation

muhammadali1658
Copy link
Contributor

@muhammadali1658 muhammadali1658 commented Feb 20, 2025 •
edited
Loading

docs: Fix styling of a link which was producing poor visibility in dark mode.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from kirjs February 20, 2025 17:29
@angular-robot angular-robot bot added the area: docs Related to the documentation label Feb 20, 2025
@ngbot ngbot bot added this to the Backlog milestone Feb 20, 2025
@github-actions GitHub Actions
Copy link

Deployed adev-preview for 67d606e to: https://ng-dev-previews-fw--pr-angular-angular-60037-adev-prev-zojb9kcg.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@muhammadali1658
Copy link
Contributor Author

Please verify the difference in visibility between old styling and new one.

BEFORE:
Before

AFTER:
After

JeanMeche
JeanMeche requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idealy, we should fix this in the styling directly to support this usecase !

@JeanMeche
Copy link
Member

Since no change was provided, we'll close it.

@JeanMeche JeanMeche closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche requested changes

@kirjs kirjs Awaiting requested review from kirjs

Assignees
No one assigned
Labels
adev: preview area: docs Related to the documentation
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@muhammadali1658 @JeanMeche