Skip to content

gh-127440: Try using base_executable to detect prefix and exec_prefix#127441

Open
CharlieZhao95 wants to merge 10 commits into
python:mainfrom
CharlieZhao95:fix_bad_venv
Open

gh-127440: Try using base_executable to detect prefix and exec_prefix#127441
CharlieZhao95 wants to merge 10 commits into
python:mainfrom
CharlieZhao95:fix_bad_venv

Conversation

@CharlieZhao95
Copy link
Copy Markdown
Contributor

@CharlieZhao95 CharlieZhao95 commented Nov 30, 2024 •
edited by bedevere-app Bot
Loading

Detect prefix and exec_prefix by searching from real executable(base_executable) location for the stdlib_dir.

@ghost
Copy link
Copy Markdown

ghost commented Nov 30, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Nov 30, 2024
Open
@CharlieZhao95 CharlieZhao95 marked this pull request as ready for review December 2, 2024 02:57
@CharlieZhao95 CharlieZhao95 requested a review from FFY00 as a code owner December 2, 2024 02:57
@FFY00

This comment was marked as outdated.

Sign in to view
FFY00
FFY00 requested changes Dec 12, 2024
View reviewed changes
Comment thread Modules/getpath.py
Comment thread Modules/getpath.py Outdated
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Dec 12, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@CharlieZhao95 CharlieZhao95 requested a review from FFY00 December 25, 2024 08:40
@CharlieZhao95
Copy link
Copy Markdown
Contributor Author

CharlieZhao95 commented Jan 17, 2025

@FFY00 A friendly reminder :) Do we need to continue this PR or start a new backport?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CharlieZhao95 @FFY00