Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): move DOM manipulation logic to its own file #59462

Closed
wants to merge 1 commit into from
Closed

refactor(core): move DOM manipulation logic to its own file #59462

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

This refactoring takes a step toward breaking down the node_manipulation file into smaller, more focused files.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jan 10, 2025
@ngbot ngbot bot added this to the Backlog milestone Jan 10, 2025
@pkozlowski-opensource pkozlowski-opensource force-pushed the runtime_refactor_node_manipulation branch from c6fe6eb to 49e2c65 Compare January 10, 2025 12:18
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Jan 10, 2025
@ngbot ngbot bot modified the milestone: Backlog Jan 10, 2025
@pkozlowski-opensource pkozlowski-opensource force-pushed the runtime_refactor_node_manipulation branch 2 times, most recently from ae80bd3 to dec8fdb Compare January 15, 2025 09:44
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review January 15, 2025 09:53
@pkozlowski-opensource pkozlowski-opensource force-pushed the runtime_refactor_node_manipulation branch from dec8fdb to 2a74260 Compare January 15, 2025 11:02
@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 15, 2025
@pkozlowski-opensource pkozlowski-opensource force-pushed the runtime_refactor_node_manipulation branch 2 times, most recently from 9e0dda4 to 4c84a50 Compare January 16, 2025 12:27
@pkozlowski-opensource
refactor(core): move DOM manipulation logic to its own file
5e62f3e 
This refactoring takes a step toward breaking down the
node_manipulation file into smaller, more focused files.
@pkozlowski-opensource pkozlowski-opensource force-pushed the runtime_refactor_node_manipulation branch from 4c84a50 to 5e62f3e Compare January 16, 2025 13:01
alxhub
alxhub approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: global-approvers

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 16, 2025
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 10f280a.

The changes were merged into the following branches: main, 19.1.x

AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2025
@pkozlowski-opensource @AndrewKushnir
refactor(core): move DOM manipulation logic to its own file (#59462)
8b08a25 
This refactoring takes a step toward breaking down the
node_manipulation file into smaller, more focused files.

PR Close #59462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelbourn jelbourn jelbourn left review comments

@crisbeto crisbeto crisbeto approved these changes

@alxhub alxhub alxhub approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@pkozlowski-opensource @AndrewKushnir @jelbourn @alxhub @crisbeto