Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90562: Mention slots pitfall in dataclass docs #107391

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+4 ∄1�71
Open

gh-90562: Mention slots pitfall in dataclass docs #107391

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e40f5f9
Mention slots pitfall in dataclass docs
thejcannon Jul 28, 2023
e9930d7
Update dataclasses.rst
thejcannon Jul 28, 2023
91bbbd2
Update dataclasses.rst
thejcannon Jul 28, 2023
08903c5
Double trouble
thejcannon Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion Doc/library/dataclasses.rst
View file
Open in desktop
Expand Up @@ -185,7 +185,10 @@ Module contents
- ``slots``: If true (the default is ``False``), :attr:`~object.__slots__` attribute
will be generated and new class will be returned instead of the original one.
If :attr:`~object.__slots__` is already defined in the class, then :exc:`TypeError`
is raised.
is raised. Calling no-arg ``super()`` in dataclasses using ``slots=True`` will result in
the following Exception being raised:
``TypeError: super(type, obj): obj must be an instance or subtype of type``.
The two-arg ``super()`` is a valid workaround. See :issue:`46404` for full details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to capture everything relevant in the documentation -- what is relevant to the reader from the linked issue that isn't captured in your summary?

A

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two points are it. What to look for and how to workaround.


.. versionadded:: 3.10

Expand Down