Skip to content

gh-126731: Update outdated project information in pprint.pp doc #126732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2024
Merged

gh-126731: Update outdated project information in pprint.pp doc #126732

merged 3 commits into from
Nov 14, 2024

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Nov 12, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 12, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 12, 2024
Closed
@Eclips4
Copy link
Member

Eclips4 commented Nov 12, 2024

Sorry, but I'm against this change. It looks too big for our documentation, and it doesn't add any clarification, in my opinion. I think the suggestion from Brian (#126731 (comment)) would look more accurate.

@Wulian233
Copy link
Contributor Author

Oops, I saw the suggestion in the issue first and pin version, do I need to cancel the change again and just change the fixed version (I'd love to do it)

@Eclips4
Copy link
Member

Eclips4 commented Nov 12, 2024

Oops, I saw the suggestion in the issue first and pin version, do I need to cancel the change again and just change the fixed version (I'd love to do it)

Yeah, I would like to see just a pinning to 1.2.0

@hugovk
Copy link
Member

hugovk commented Nov 12, 2024

If pinning to anything, shall we pin to the old version 1.2.0 because it's much shorter? It doesn't matter what is in the response, merely that we get a bunch of JSON and that it's printed prettily.

@Eclips4
Copy link
Member

Eclips4 commented Nov 12, 2024

If pinning to anything, shall we pin to the old version 1.2.0 because it's much shorter? It doesn't matter what is in the response, merely that we get a bunch of JSON and that it's printed prettily.

I would like to see a pin to 1.2.0, just because it is shorter, yes.

@Wulian233
Copy link
Contributor Author

Thanks your suggestions! I have made changes!

@Eclips4 Eclips4 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 12, 2024
Eclips4
Eclips4 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

hauntsaninja
hauntsaninja approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like PyPI now also returns yanked and yanked_reason, but I don't think adding those really helps anything here. Thanks for the update!

@hauntsaninja hauntsaninja merged commit 6a93a1a into python:main Nov 14, 2024
33 checks passed
@miss-islington-app
Copy link

Thanks @Wulian233 for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤄1�7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 14, 2024
@Wulian233 @miss-islington
pythongh-126731: Update outdated project information in pprint.pp d 1�7
b992d98 
…oc (pythonGH-126732)

(cherry picked from commit 6a93a1a)

Co-authored-by: Wulian <xiguawulian@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 14, 2024

GH-126818 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 14, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 14, 2024
@Wulian233 @miss-islington
pythongh-126731: Update outdated project information in pprint.pp d 1�7
836e0f1 
…oc (pythonGH-126732)

(cherry picked from commit 6a93a1a)

Co-authored-by: Wulian <xiguawulian@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 14, 2024

GH-126819 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 14, 2024
hauntsaninja pushed a commit that referenced this pull request Nov 14, 2024
@miss-islington @Wulian233
[3.13] gh-126731: Update outdated project information in pprint.pp  1�7
75d6431 
…doc (GH-126732) (#126818)

gh-126731: Update outdated project information in `pprint.pp` doc (GH-126732)
(cherry picked from commit 6a93a1a)

Co-authored-by: Wulian <xiguawulian@gmail.com>
hauntsaninja pushed a commit that referenced this pull request Nov 14, 2024
@miss-islington @Wulian233
[3.12] gh-126731: Update outdated project information in pprint.pp  1�7
3ed99b3 
…doc (GH-126732) (#126819)

gh-126731: Update outdated project information in `pprint.pp` doc (GH-126732)
(cherry picked from commit 6a93a1a)

Co-authored-by: Wulian <xiguawulian@gmail.com>
@Wulian233 Wulian233 deleted the pprint-doc branch November 14, 2024 10:15
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@Wulian233 @picnixz
pythongh-126731: Update outdated project information in pprint.pp d 1�7
2c4d5ee 
…oc (python#126732)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@Wulian233 @ebonnal
pythongh-126731: Update outdated project information in pprint.pp d 1�7
c81aa2d 
…oc (python#126732)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wulian233 @Eclips4 @hugovk @hauntsaninja