test: add mixed number types for LocalMaximomPoint tests#1668
test: add mixed number types for LocalMaximomPoint tests#1668taekim-dev wants to merge 6 commits into
Conversation
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
I don't think these help coverage since the algorithm is independent of the specific numbers and just cares about the ordering.
If we're seeing this as contract-based testing, I also consider it a bit dubious that you expect a specific maximum when there are multiple valid return values (as is the case in your first test).
All in all, I'm afraid I wouldn't support this PR - I don't see the benefit it brings.
ps. you also seem to have unrelated changes in here, though that would be easy to fix.
|
@appgurueu Thank you for your feedback. Based on your insights, I have adjusted the test cases to align with the behavior of the existing algorithm. I recognize the limitation of the original algorithm in not always returning the first local maximum. Your feedback on further improvements is welcomed. |
2 participants
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.