fix(http): preserve all headers from Headers object #57802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
the
area: common/http
alan-agius4
added
the
action: review
alxhub
approved these changes
Sep 24, 2024
alxhub
added
action: merge
when initialized from a `Headers` object containing multiple values for the same header, `HttpHeaders` now contains all the header values instead of only having one of them. Fixes angular#57798
jnizet
force-pushed
the
fix/57798-multiple-headers
branch
from
f407bee to
44d7747
Compare
angular-robot
bot
removed
the
area: common/http
pkozlowski-opensource
added
the
area: common/http
|
This PR was merged into the repository by commit 057cf7f. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when initialized from a
Headersobject containing multiple values for the same header,HttpHeadersnow contains all the header values instead of only having one of them.Fixes #57798
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When initialized from a
Headersobject containing multiple values for the same header,HttpHeaderscontained only one of the header values.Issue Number: #57798
What is the new behavior?
It now contains all the header values, as in the original
Headersobject.Does this PR introduce a breaking change?
(It does change the behavior of the HttpHeaders class, which might cause behavior changes in existing code, but the old behavior was a bug).