Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: declare Event Replay feature as stable #57895

Closed

Conversation

AndrewKushnir
Copy link
Contributor

This commit drops the @developerPreview annotation from the withEventReplay() function, which effectively makes the Event Replay feature stable.

cc @alan-agius4 @iteriani @tbondwilkinson @thePunderWoman

Does this PR introduce a breaking change?

  • Yes
  • No

This commit drops the `@developerPreview` annotation from the `withEventReplay()` function, which effectively makes the Event Replay feature stable.
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: docs Related to the documentation labels Sep 20, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 20, 2024
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥🔥🔥

@JeanMeche
Copy link
Member

@AndrewKushnir We probably should also update adev/src/content/reference/roadmap.md where Event Replay is also mentionned.

@AndrewKushnir
Copy link
Contributor Author

We probably should also update adev/src/content/reference/roadmap.md where Event Replay is also mentionned

@JeanMeche thanks for the comment. Minko or Mark will be doing an update to the Roadmap closer to v19 release date and they'll use the most up-to-date info for all "in progress" features at that time.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 21, 2024
@AndrewKushnir AndrewKushnir removed the request for review from iteriani September 21, 2024 01:30
@AndrewKushnir
Copy link
Contributor Author

Caretaker note: no presubmit required, docs-only change.

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Sep 23, 2024
…lientHydration` for new SSR apps

Event Replay is now stable (see angular/angular#57895). This commit adds `withEventReplay()` to the `provideClientHydration()` call in newly created Angular applications with SSR.
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Sep 23, 2024
…lientHydration` for new SSR apps

Event Replay is now stable (see angular/angular#57895). This commit adds `withEventReplay()` to the `provideClientHydration()` call in newly created Angular applications with SSR.
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Sep 23, 2024
…lientHydration` for new SSR apps

Event Replay is now stable (see angular/angular#57895). This commit adds `withEventReplay()` to the `provideClientHydration()` call in newly created Angular applications with SSR.
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 6b23953.

The changes were merged into the following branches: main

alan-agius4 added a commit to angular/angular-cli that referenced this pull request Sep 23, 2024
…lientHydration` for new SSR apps

Event Replay is now stable (see angular/angular#57895). This commit adds `withEventReplay()` to the `provideClientHydration()` call in newly created Angular applications with SSR.
and-oli pushed a commit to and-oli/angular that referenced this pull request Sep 30, 2024
This commit drops the `@developerPreview` annotation from the `withEventReplay()` function, which effectively makes the Event Replay feature stable.

PR Close angular#57895
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants