feat(@angular-devkit/build-angular): support karma with application builder #28416
+260
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the tests have a hard time on modern macOS, mostly because of how Bazel handles file paths with whitespace. By running those tests inside of a Linux container, they can pass. Longer term, it would be great if running all tests outside of Linux would work but that's a taller order.
angular-robot
bot
added
detected: feature
jkrems
force-pushed
the
jk-karma-app-builder
branch
2 times, most recently
from
460c6b7
to
0aec0d9
Compare
jkrems
force-pushed
the
jk-karma-app-builder
branch
from
0aec0d9
to
4187a63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information