feat(compiler): add diagnostic for unused standalone imports #57605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
force-pushed
the
unused-decls
branch
2 times, most recently
from
c77400d
to
c55f855
Compare
angular-robot
bot
added
the
area: language-service
|
Pushed a change to add an automatic code fix to the language service. |
crisbeto
force-pushed
the
unused-decls
branch
from
959b2bd
to
2082a98
Compare
crisbeto
commented
Sep 2, 2024
| * Whether the rule to check for unused standalone declarations is enabled. | ||
| * Used to disable it conditionally in internal builds. | ||
| */ | ||
| export const UNUSED_STANDALONE_DECLARATIONS_RULE_ENABLED = true; |
There was a problem hiding this comment.
Context for this is that the new rule is somewhat breaking internally. This flag is in a separate file so we can easily apply a patch to disable it.
crisbeto
added
the
merge: caretaker note
|
Caretaker note: these changes require a new patch internally. The patch is in cl/670184686 |
atscott
approved these changes
Sep 3, 2024
crisbeto
force-pushed
the
unused-decls
branch
from
2082a98
to
662e5eb
Compare
atscott
approved these changes
Sep 3, 2024
alxhub
approved these changes
Sep 3, 2024
atscott
approved these changes
Sep 3, 2024
Adds a new diagnostic that will report cases where a declaration is in the `imports` array, but isn't being used anywhere. The diagnostic is reported as a warning by default and can be controlled using the following option in the tsconfig:
```
{
"angularCompilerOptions": {
"extendedDiagnostics": {
"checks": {
"unusedStandaloneImports": "suppress"
}
}
}
}
```
**Note:** I'll look into a codefix for the language service in a follow-up.
Fixes angular#46766.
Adds an automatic code fix to the language service that will remove unused standalone imports.
crisbeto
force-pushed
the
unused-decls
branch
from
662e5eb
to
aeda915
Compare
crisbeto
removed request for
pkozlowski-opensource,
thePunderWoman and
dylhunn
crisbeto
added
action: merge
|
This PR was merged into the repository by commit 8da9fb4. The changes were merged into the following branches: main |
mvdluit
pushed a commit
to mvdluit/angular
that referenced
this pull request
Sep 5, 2024
…#57605) Adds a new diagnostic that will report cases where a declaration is in the `imports` array, but isn't being used anywhere. The diagnostic is reported as a warning by default and can be controlled using the following option in the tsconfig: ``` { "angularCompilerOptions": { "extendedDiagnostics": { "checks": { "unusedStandaloneImports": "suppress" } } } } ``` **Note:** I'll look into a codefix for the language service in a follow-up. Fixes angular#46766. PR Close angular#57605
mvdluit
pushed a commit
to mvdluit/angular
that referenced
this pull request
Sep 5, 2024
…ngular#57605) Adds an automatic code fix to the language service that will remove unused standalone imports. PR Close angular#57605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new diagnostic that will report cases where a declaration is in the
importsarray, but isn't being used anywhere. The diagnostic is reported as a warning by default and can be controlled using the following option in the tsconfig:Fixes #46766.