Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Do not run image performance warning checks on server #57234

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Aug 1, 2024

These checks require document so they should not be run on the server.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Aug 1, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 1, 2024
@atscott atscott added the target: patch This PR is targeted for the next patch release label Aug 1, 2024
These checks require document so they should not be run on the server.
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Aug 2, 2024
@JeanMeche
Copy link
Member

Note: this doesn't merge correctly into 18.1.x because of #57060.

@JeanMeche JeanMeche added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 2, 2024
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 827070e.

The changes were merged into the following branches: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants