gh-123174: Add proto parameter to sock_connect #123175
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aperence
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Allow the selection of the protocol used by getaddrinfo by adding an additional, optional parameter proto_addr_info. If not specified, use the protocol used by the socket (= previous behaviour) This change is needed to allow custom protocols to be used with the sock_connect, because these protocols may raise an error when calling getaddrinfo (result in a "ai_proto not supported" error) An example of such protocol is MPTCP (https://mptcp.dev)
Aperence
force-pushed
the
fix-issue-123174
branch
from
f3b91ee to
9e19f40
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
The following commit authors need to sign the Contributor License Agreement: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the selection of the protocol used by
getaddrinfoby adding an additional, optional parameterproto_addr_info.If not specified, use the protocol used by the socket (= previous behaviour).
This change is needed to allow custom protocols to be used with
sock_connect, because these protocols may raise an error when callinggetaddrinfo(result in aai_proto not supportederror).An example of such protocol is MPTCP (https://mptcp.dev)
proto_addr_infoargument to sock_connect in asyncio #123174